Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()
From: Jes Sorensen
Date: Wed Oct 12 2016 - 08:19:04 EST
Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> foo = kmalloc(sizeof(*foo), GFP_KERNEL);
> This says you are allocating enough space for foo. It can be reviewed
> by looking at one line. If you change the type of foo it will still
> foo = kmalloc(sizeof(struct whatever), GFP_KERNEL);
> There isn't enough information to say if this is correct. If you change
> the type of foo then you have to update the allocation as well.
> It's not a super common type of bug, but I see it occasionally.
I know what you are saying, but the latter in my book is easier to read
and reminds you what the type is when you review the code.
Point being this comes down to personal preference and stating that the
former is the right way or making that a rule and using checkpatch to
harrass people with patches to change it is bogus.