Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()

From: Benjamin Tissoires
Date: Wed Oct 12 2016 - 12:55:18 EST


On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires
<benjamin.tissoires@xxxxxxxxxx> wrote:
> From: David Arcari <darcari@xxxxxxxxxx>
>
> acpi_dev_gpio_irq_get() currently ignores the error returned
> by acpi_get_gpiod_by_index() and overwrites it with -ENOENT.
>
> Problem is this error can be -EPROBE_DEFER, which just blows
> up some drivers when the module ordering is not correct.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: David Arcari <darcari@xxxxxxxxxx>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> ---
>
> Hi David,
>
> I am planning on sending this to the list, any last minute comments?

Of course, I forgot to remove our internal sync comment.
David's answer was "No. This looks good to me.", so I just went ahead
and send the patch.

Cheers,
Benjamin