Re: [PATCH] perf jit: Fix build issue on Ubuntu

From: Stephane Eranian
Date: Thu Oct 13 2016 - 03:43:45 EST


On Wed, Oct 12, 2016 at 7:20 PM, Anton Blanchard <anton@xxxxxxxxxx> wrote:
>
> From: Anton Blanchard <anton@xxxxxxxxx>
>
> When building on Ubuntu 16.04, I get the following error:
>
> Makefile:49: *** the openjdk development package appears to me missing, install and try again. Stop.
>
> The problem is that update-java-alternatives has multiple spaces between
> fields, and cut treats each space as a new delimiter:
>
> java-1.8.0-openjdk-ppc64el 1081 /usr/lib/jvm/java-1.8.0-openjdk-ppc64el
>
> Fix this by using awk, which handles this fine.
>
> Signed-off-by: Anton Blanchard <anton@xxxxxxxxx>

Works for me. Thanks.
Reviewed-by: Stephane Eranian <eranian@xxxxxxxxxx>

>
> ---
> tools/perf/jvmti/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/jvmti/Makefile b/tools/perf/jvmti/Makefile
> index 5ce61a1..df14e6b 100644
> --- a/tools/perf/jvmti/Makefile
> +++ b/tools/perf/jvmti/Makefile
> @@ -36,7 +36,7 @@ SOLIBEXT=so
> # The following works at least on fedora 23, you may need the next
> # line for other distros.
> ifneq (,$(wildcard /usr/sbin/update-java-alternatives))
> -JDIR=$(shell /usr/sbin/update-java-alternatives -l | head -1 | cut -d ' ' -f 3)
> +JDIR=$(shell /usr/sbin/update-java-alternatives -l | head -1 | awk '{print $$3}')
> else
> ifneq (,$(wildcard /usr/sbin/alternatives))
> JDIR=$(shell alternatives --display java | tail -1 | cut -d' ' -f 5 | sed 's%/jre/bin/java.%%g')
> --
> 2.7.4
>