Re: [PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

From: Hannes Reinecke
Date: Thu Oct 13 2016 - 07:28:24 EST


On 10/12/2016 03:06 PM, Johannes Thumshirn wrote:
> Export fc_bsg_jobdone so drivers can use it directly instead of doing
> the round-trip via struct fc_bsg_job::job_done() and use it in the LLDDs.
>
> As we've converted all LLDDs over to use fc_bsg_jobdone() directly,
> we can remove the function pointer from struct fc_bsg_job as well.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> ---
> drivers/s390/scsi/zfcp_fc.c | 2 +-
> drivers/scsi/bfa/bfad_bsg.c | 4 ++--
> drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
> drivers/scsi/libfc/fc_lport.c | 4 ++--
> drivers/scsi/lpfc/lpfc_bsg.c | 38 +++++++++++++++++-----------------
> drivers/scsi/qla2xxx/qla_bsg.c | 44 ++++++++++++++++++++--------------------
> drivers/scsi/scsi_transport_fc.c | 5 ++---
> include/scsi/scsi_transport_fc.h | 2 +-
> 8 files changed, 50 insertions(+), 51 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)