Re: [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines

From: Jean Delvare
Date: Thu Oct 13 2016 - 07:36:20 EST


On Tue, 11 Oct 2016 19:03:56 -0700, Joe Perches wrote:
> On Tue, 2016-10-11 at 18:34 +0100, Carlos Palminha wrote:
> []
> > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> []
> > @@ -260,7 +260,8 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
> > else if ((temp & 0x0E) == 0)
> > dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus\n");
> > else
> > - dev_err(&PIIX4_dev->dev, "Illegal Interrupt configuration "
> > + dev_err(&PIIX4_dev->dev,
> > + "Illegal Interrupt configuration "
> > "(or code out of date)!\n");
>
> typically, this format would be coalesced into a single line.

Especially when the patch claims to "fix quoted string split across
lines" :-D

--
Jean Delvare
SUSE L3 Support