Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

From: David Miller
Date: Thu Oct 13 2016 - 10:46:45 EST

From: Zach Brown <zach.brown@xxxxxx>
Date: Tue, 11 Oct 2016 15:26:20 -0500

> From: Josh Cartwright <josh.cartwright@xxxxxx>
> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
> create a set of led triggers for each instantiated PHY device. There is
> one LED trigger per link-speed, per-phy.
> This allows for a user to configure their system to allow a set of LEDs
> to represent link state changes on the phy.
> Signed-off-by: Josh Cartwright <josh.cartwright@xxxxxx>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@xxxxxx>
> Signed-off-by: Zach Brown <zach.brown@xxxxxx>
> + static const char * const name_suffix[] = {
> + "10Mbps",
> + "100Mbps",
> + "1Gbps",
> + "2.5Gbps",
> + "10Gbps",

This choice of both the array size and the speeds to support seems
entirely arbitrary and is inappropriate for a generic driver of this

This seems to be hard coding this to support the list of speeds
supported by whatever driver you want to use with this new LED
facility, and sorry that's not how we build nice generic pieces of