Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes

From: Carlos Palminha
Date: Thu Oct 13 2016 - 12:45:00 EST


Hi Jean,

On 13-10-2016 12:40, Jean Delvare wrote:
> Hi Carlos,
>
> On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote:
>> This patchset fixes several coding style issues.
>>
>> Carlos Palminha (5):
>> i2c: i2c-piix4: coding style fix - '*' adjacent to data name
>> i2c: i2c-piix4: coding style fix - assignment in if condition
>> i2c: i2c-piix4: coding style fix - long comments blocks
>> i2c: i2c-piix4: coding style fix - spaces with open parenthesis
>> i2c: i2c-piix4: coding style fix - quoted string split across lines
>>
>> drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------
>> 1 file changed, 82 insertions(+), 62 deletions(-)
>
> Except for the two issues which were already pointed out, I'm fine with
> these changes, however there is no good reason to split them into 5
> separate patches. Fixing the coding style is one goal, it should be all
> done with a single patch. So, when you resubmit, please do so as a
> single patch.
>
> Thanks,
>

Sure... I'll resubmit as one patch.

Regards,
C.Palminha