Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm
Date: Thu Oct 13 2016 - 19:51:41 EST
On 2016/10/14 7:37, Tejun Heo wrote:
> Hello, Zijun.
> On Tue, Oct 11, 2016 at 08:48:45PM +0800, zijun_hu wrote:
>> compared with the original algorithm theoretically and practically, the
>> new one educes the same grouping results, besides, it is more effective,
>> simpler and easier to understand.
> If the original code wasn't broken and the new code produces the same
> output, I'd really not mess with this code. There simply is no upside
> to messing with this code. It's run once during boot and never a
> noticeable contributor of boot overhead. Maybe the new code is a bit
> simpler and more efficient but the actual benefit is so small that any
> risk would outweigh it.
the main intent of this change is making the CPU grouping algorithm more
easily to understand, especially, for newcomer for memory managements
take me as a example, i really take me a longer timer to understand it