RE: [PATCH] qed: fix old-style function definition

From: Mintz, Yuval
Date: Thu Oct 13 2016 - 20:00:45 EST


> > The definition of qed_get_rdma_ops() is not a prototype unless we add
> > 'void' here, as indicated by this W=1 warning:
> >
> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ʽqed_get_rdma_opsʼ:
> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
> > function definition [-Werror=old-style-definition]
> >
> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Again, Qlogic folks, please properly review patches posted against your driver.
>
> Thanks.

Sorry, managed to miss this one.
Acked-by: Yuval Mintz <Yuval.Mintz@xxxxxxxxxxxxxxxxxx>