Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
From: Ard Biesheuvel
Date: Fri Oct 14 2016 - 09:15:14 EST
On 14 October 2016 at 14:10, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>> So use kzalloc
> Do we really need kzalloc()? We have things on the stack right now, and
> don't initialize, so surely we don't really need to zero things?
>> This only addresses one half of the problem. The other problem, i.e.,
>> the fact that the aad array lives on the stack of the caller, is
>> handled adequately imo by the change proposed by Johannes.
> But if we allocate things anyway, is it worth expending per-CPU buffers
> on these?
Ehmm, maybe not. I could spin a v2 that allocates a bigger buffer, and
copies aad into it as well
That does not help the other algos though