Re: [PATCH 01/10] perf, tools: Factor out scale conversion code
From: Andi Kleen
Date: Fri Oct 14 2016 - 12:15:24 EST
On Fri, Oct 14, 2016 at 01:08:42PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 14, 2016 at 08:45:15AM -0700, Andi Kleen escreveu:
> > > So if we can't convert the scale because of an allocation failure
> > > related to locale issues we silently trow it away and do no scale at
> > > all?
> > That is right. If your machine is thrashing to death in a OOM this
> > is your smallest problem.
> Please keep it was before, i.e. return an error value, and bail out. It
> was like that before, why introduce these kinds of silent "do something
> else in an unlikely case" handling?
Ok. I will fix it.
But just for the record I don't think this fine grained memory error
handling makes any sense for perf. It is needed in the kernel, but
it's not appropiate for user programs:
- Usually when you're out of memory then every thing afterward
that needs memory will fail too, so there's no sane way to continue,
- When you run out of memory in user space you usually get killed
at some point anyways because the OOM killer kicks in.
- The only exception is that you run out of VA space, but then the point
- These error paths are all untested and most likely a significant
fraction of them is broken because untested code is often broken.
What most user space does is to just have malloc wrappers that
exit when you run out of memory with an error message. That's nearly
always the right strategy for user programs.