Re: [PATCH 2/2] watchdog: max77620_wdt: fix module autoload

From: Guenter Roeck
Date: Fri Oct 14 2016 - 12:56:23 EST


On Fri, Oct 14, 2016 at 12:23:51PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ $ modinfo drivers/watchdog/max77620_wdt.ko | grep alias
> $
>
> After this patch:
>
> modinfo drivers/watchdog/max77620_wdt.ko | grep alias
> alias: platform:max77620-watchdog
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> drivers/watchdog/max77620_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c
> index 48b84df2afda..68c41fa2be27 100644
> --- a/drivers/watchdog/max77620_wdt.c
> +++ b/drivers/watchdog/max77620_wdt.c
> @@ -205,6 +205,7 @@ static struct platform_device_id max77620_wdt_devtype[] = {
> { .name = "max77620-watchdog", },
> { },
> };
> +MODULE_DEVICE_TABLE(platform, max77620_wdt_devtype);
>
> static struct platform_driver max77620_wdt_driver = {
> .driver = {
> --
> 2.7.4
>