Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

From: hpa
Date: Sun Oct 16 2016 - 14:45:11 EST


On October 16, 2016 9:35:57 AM PDT, Borislav Petkov <bp@xxxxxxxxx> wrote:
>On Sun, Oct 16, 2016 at 09:02:51AM -0700, hpa@xxxxxxxxx wrote:
>> No, please. That would be worse than the disease.
>
>Why not?
>
>I did that recently with a bunch of leaves and there were no issues:
>
>2ccd71f1b278 ("x86/cpufeature: Move some of the scattered feature bits
>to x86_capability")
>
>There it obviously made sense for 0x00000006 and 0x8000000a to have a
>separate ->x86_capability leaf.

It's needlessly adding complexity for no reason, at least for the leaves that are going to add bits over time. The x86_capability array is not an expensive resource.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.