Re: [PATCH] mtd: nand: omap2: Fix module autoload

From: Boris Brezillon
Date: Mon Oct 17 2016 - 16:21:08 EST


On Mon, 17 Oct 2016 13:19:37 -0300
Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mtd/nand/omap2_nand.ko | grep alias
> alias: platform:omap2-nand
>
> After this patch:
>
> $ modinfo drivers/mtd/nand/omap2_nand.ko | grep alias
> alias: platform:omap2-nand
> alias: of:N*T*Cti,omap2-nandC*
> alias: of:N*T*Cti,omap2-nand
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Applied.

Thanks,

Boris

>
> ---
>
> drivers/mtd/nand/omap2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 5513bfd9cdc9..0934c3b3f70e 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -2197,6 +2197,7 @@ static const struct of_device_id omap_nand_ids[] = {
> { .compatible = "ti,omap2-nand", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, omap_nand_ids);
>
> static struct platform_driver omap_nand_driver = {
> .probe = omap_nand_probe,