Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported

From: David Miller
Date: Tue Oct 18 2016 - 10:30:25 EST


From: Niklas Cassel <niklas.cassel@xxxxxxxx>
Date: Tue, 18 Oct 2016 09:20:33 +0200

> From: Niklas Cassel <niklas.cassel@xxxxxxxx>
>
> phy_device->supported is originally set by the PHY driver.
> The ethernet driver should filter phy_device->supported to only contain
> flags supported by the IP.
> The IP supports setting rx and tx flow control independently,
> therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
> If the flags are cleared, pause frames cannot be enabled (even if they
> are supported by the PHY).
>
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxx>
> Signed-off-by: Jesper Nilsson <jespern@xxxxxxxx>
> Acked-by: Lars Persson <larper@xxxxxxxx>

Applied.