Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported

From: Rob Herring
Date: Tue Oct 18 2016 - 10:33:16 EST


On Fri, Oct 14, 2016 at 05:52:50PM +0100, Luis.Oliveira@xxxxxxxxxxxx wrote:
> From: Luis Oliveira <lolivei@xxxxxxxxxxxx>
>
> Signed-off-by: Luis Oliveira <lolivei@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/i2c/i2c-designware.txt | 5 ++++-
> drivers/i2c/busses/i2c-designware-platdrv.c | 4 +++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> index fee26dc..d3d163c 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> @@ -19,6 +19,8 @@ Optional properties :
>
> - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds.
> This value which is by default 300ns is used to compute the tHIGH period.
> +
> + - is-slave : indicates if the block is a I2C slave device.

This should be documented as a generic property.

>
> Example :
>
> @@ -30,7 +32,7 @@ Example :
> interrupts = <11>;
> clock-frequency = <400000>;
> };
> -
> +

Adding trailing whitespace...

> i2c@1120000 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -42,4 +44,5 @@ Example :
> i2c-sda-hold-time-ns = <300>;
> i2c-sda-falling-time-ns = <300>;
> i2c-scl-falling-time-ns = <300>;
> + is-slave;
> };