Re: [PATCH] pinctrl: st: don't specify default interrupt trigger

From: Peter Griffin
Date: Thu Oct 20 2016 - 07:57:01 EST


Hi Patrice,

On Thu, 20 Oct 2016, Patrice Chotard wrote:

>
>
> On 10/18/2016 09:16 AM, patrice.chotard@xxxxxx wrote:
> > From: Patrice Chotard <patrice.chotard@xxxxxx>
> >
> > Thanks to 332e99d5ae4 which now alerts of default
> > trigger usage when configuring interrupts.
> >
> > Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxx>
> > ---
> > drivers/pinctrl/pinctrl-st.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> > index 99da4cf..b7bb371 100644
> > --- a/drivers/pinctrl/pinctrl-st.c
> > +++ b/drivers/pinctrl/pinctrl-st.c
> > @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
> > if (info->irqmux_base || gpio_irq > 0) {
> > err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip,
> > 0, handle_simple_irq,
> > - IRQ_TYPE_LEVEL_LOW);
> > + IRQ_TYPE_NONE);
> > if (err) {
> > gpiochip_remove(&bank->gpio_chip);
> > dev_info(dev, "could not add irqchip\n");
> >
>
> Hi Linus
>
> I forgot to mention that this patch is dedicated for v4.9-rcs

Wow, v4.9-rc is a noisy boot without this patch :)

Acked-by: Peter Griffin <peter.griffin@xxxxxxxxxx>