Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

From: Stefan Wahren
Date: Fri Oct 21 2016 - 07:38:51 EST


Am 18.10.2016 um 20:30 schrieb David Miller:
> From: Stefan Wahren <stefan.wahren@xxxxxxxx>
> Date: Tue, 18 Oct 2016 13:27:34 +0200
>
>> +void
>> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
>> + int count)
>> +{
>> + struct qcauart *qca = tty->disc_data;
>> + struct net_device_stats *n_stats = &qca->net_dev->stats;
>> + int dropped = 0;
> Please order local variable declarations from longest to shortest line.

Even if the current second init depends on the first one?