Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities

From: Jarkko Sakkinen
Date: Fri Oct 21 2016 - 16:33:54 EST


On Mon, Sep 19, 2016 at 05:24:06PM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote:
> > From: Ed Swierk <eswierk@xxxxxxxxxxxxxxxxxx>
> >
> > Call tpm_getcap() from tpm_get_timeouts() to eliminate redundant
> > code. Return all errors to the caller rather than swallowing them
> > (e.g. when tpm_transmit_cmd() returns nonzero).
>
> I didn't look at these closely, but I agree with the idea.

Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko