Re: [PATCH] clk: keystone: Fix an error checking

From: Dan Carpenter
Date: Mon Oct 24 2016 - 06:36:44 EST


On Sun, Oct 23, 2016 at 10:12:49AM +0200, Christophe JAILLET wrote:
> clk_register_pll() can return ERR_PTR(-ENOMEM) so here the check against
> NULL only is not correct.
>

Change the ERR_PTR(-ENOMEM) to a NULL instead. When we mix error
pointers and NULL, what it means is that NULL should be treated as a
success case. That's not the case here, so we should just return NULL
since we don't actually care about the error codes.

regards,
dan carpenter