Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible

From: Daniel Vetter
Date: Mon Oct 24 2016 - 10:27:55 EST


On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks this function with 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> >
>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch