Re: [PATCH 2/3] perf sched map: Always show task comm with -v

From: Jiri Olsa
Date: Mon Oct 24 2016 - 12:52:27 EST


On Mon, Oct 24, 2016 at 11:02:44AM +0900, Namhyung Kim wrote:
> I'd like to see the name of tasks with perf sched map, but it only shows
> name of new tasks and then use short names after all. This is not good
> for long running tasks since it's hard for users to track the short
> names. This patch makes it show the names (except the idle task) when
> -v option is used. Probably we may make it as default behavior.
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> ---
> tools/perf/builtin-sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 78006e991d91..97d6cbf486bb 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1493,7 +1493,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> goto out;
>
> color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
> - if (new_shortname) {
> + if (new_shortname || (verbose && sched_in->tid)) {
> const char *pid_color = color;
>
> if (thread__has_color(sched_in))
> --
> 2.10.0
>