Re: [PATCH] perf hist browser: Fix hierarchy column counts

From: Markus Trippelsdorf
Date: Mon Oct 24 2016 - 15:38:20 EST


On 2016.10.24 at 19:00 +0200, Markus Trippelsdorf wrote:
> On 2016.10.25 at 01:21 +0900, Namhyung Kim wrote:
> > The perf report/top on TUI supports horizontal scrolling using LEFT and
> > RIGHT keys. But it calculate the number of columns incorrectly when
> > hierarchy mode is enabled so that keep pressing RIGHT key can make the
> > output disappeared. In the hierarchy mode, all sort keys are collapsed
> > into a single column, so it needs to be applied when calculating column
> > numbers.
>
> Thanks, this is much better now.
>
> But it doesn't scroll wide enough. In "perf top" when I press the RIGHT
> key the symbols are shown on the hard left side. In "perf top --hierarchy",
> when I press the RIGHT key, there are 5 empty spaces on the left hand
> side that should be deleted.

It might be a good idea to keep the + and - signs on the left hand side
when scrolling horizontally like "perf report -g" does.

--
Markus