Re: [PATCH] can: fix warning in bcm_connect/proc_register

From: Cong Wang
Date: Mon Oct 24 2016 - 16:11:05 EST


On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp
<socketcan@xxxxxxxxxxxx> wrote:
> if (proc_dir) {
> /* unique socket address as filename */
> sprintf(bo->procname, "%lu", sock_i_ino(sk));
> bo->bcm_proc_read = proc_create_data(bo->procname, 0644,
> proc_dir,
> &bcm_proc_fops, sk);
> + if (!bo->bcm_proc_read) {
> + ret = -ENOMEM;
> + goto fail;
> + }

Well, I meant we need to call proc_create_data() once per socket,
so we need a check before proc_create_data() too.

Thanks.