Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

From: Arnd Bergmann
Date: Mon Oct 24 2016 - 16:51:39 EST


On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr)
> return result;
> }
>
> -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> {
>
> return 0;
>

This needs to be done differently:

../drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1344:12: error: 'smu7_reset_asic_tasks' defined but not used [-Werror=unused-function]

The function has no callers, so the easiest way would be to remove it
entirely, but it's possible that there are plans to add users soon.

Arnd