Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers

From: Wanpeng Li
Date: Mon Oct 24 2016 - 19:39:21 EST


2016-10-24 23:27 GMT+08:00 Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>:
> 2016-10-24 17:09+0200, Paolo Bonzini:
>> On 24/10/2016 17:03, Radim KrÄmÃÅ wrote:
> [...]
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>
>> Go ahead, squash it into 5/5 and commit to kvm/queue. :)
>
> Did that, thanks.
>
> Wanpeng, the code is now under your name so please check it and/or
> complain.

This patch 6/5 incurred regressions.

- The latency of the periodic mode which is emulated by VMX preemption
is almost the same as periodic mode which is emulated by hrtimer.
- The oneshot mode test of kvm-unit-tests/apic_timer_latency.flat almost fail.

Btw, hope you can also apply the testcase for kvm-unit-tests. :)

Regards,
Wanpeng Li