Re: [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

From: Babu Moger
Date: Tue Oct 25 2016 - 09:10:45 EST



On 10/25/2016 1:51 AM, Mathias Nyman wrote:
On 24.10.2016 17:52, Babu Moger wrote:

On 10/24/2016 5:54 AM, Yoshihiro Shimoda wrote:
Hi,

From: Mathias Nyman
Sent: Monday, October 24, 2016 6:58 PM

On 22.10.2016 01:25, Babu Moger wrote:
Never seen XHCI auto handoff working on TI and RENESAS cards.
Eventually, we force handoff. This code forces the handoff
unconditionally. It saves 5 seconds boot time for each card.

Signed-off-by: Babu Moger <babu.moger@xxxxxxxxxx>
Do the Renesas and TI controllers still advertise the extended capability
for the handoff? (XHCI_EXT_CAPS_LEGACY)
I don't see this capability. Here is lspci output.


It's not a PCI capability, it's a xhci Extended Capability.

If the capability is supported, and handoff fail, then quirk_usb_handoff_xhci() will print
"xHCI BIOS handoff failed (BIOS bug ?)"


Yes. I see these messages. After this patch I don't see these messages.

Further on in the same function we wait for the "controller not ready" bit in the status
register to clear. If that times it prints out:

"xHCI HW not ready after 5 sec (HC bug?) status"

No. I didn't see this messages.


Do you see any of these two messages in the log?

-Mathias