Re: [PATCH] iio: maxim_thermocouple: return -EINVAL on invalid read size

From: Colin Ian King
Date: Tue Oct 25 2016 - 16:05:23 EST


On 25/10/16 20:11, Lars-Peter Clausen wrote:
> On 10/25/2016 09:04 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> In the case that the read size is not 2 or 4 bytes
>> then maxim_thermocouple_read is not initializing ret and
>> hence may return early with a bogus error return or
>> just through to return with a bogos unread value in *val.
>> Fix this by setting ret to -EINVAL for invalid (unhandled)
>> read sizes.
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Again, Arnd already took the prize, https://lkml.org/lkml/2016/10/25/518
>
Not my day :-)

Colin