Re: [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type

From: Fu Wei
Date: Wed Oct 26 2016 - 04:27:35 EST


Hi Mark,

On 20 October 2016 at 23:09, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Thu, Sep 29, 2016 at 02:17:10AM +0800, fu.wei@xxxxxxxxxx wrote:
>> diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
>> index 6f06481..16dcd10 100644
>> --- a/include/clocksource/arm_arch_timer.h
>> +++ b/include/clocksource/arm_arch_timer.h
>> @@ -45,6 +45,12 @@ enum ppi_nr {
>> MAX_TIMER_PPI
>> };
>>
>> +enum spi_nr {
>> + PHYS_SPI,
>> + VIRT_SPI,
>> + MAX_TIMER_SPI
>> +};
>
> Please rename this to arch_timer_spi_nr (as with patch 1 for
> s/ppi_nr/arch_timer_ppi_nr/). With that:
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

OK, NP, done :-)

Great thanks!

>
> Thanks,
> Mark.



--
Best regards,

Fu Wei
Software Engineer
Red Hat