Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation

From: Lee Jones
Date: Wed Oct 26 2016 - 08:16:09 EST


On Sat, 01 Oct 2016, Julia Lawall wrote:

> Use the correct function name in one case and adjust a variable name to
> that of the corresponding function parameter in another case.
>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> drivers/mfd/tc3589x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 274bf39..cc9e563 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -53,7 +53,7 @@ int tc3589x_reg_read(struct tc3589x *tc3589x, u8 reg)
> EXPORT_SYMBOL_GPL(tc3589x_reg_read);
>
> /**
> - * tc3589x_reg_read() - write a single TC3589x register
> + * tc3589x_reg_write() - write a single TC3589x register
> * @tc3589x: Device to write to
> * @reg: Register to read
> * @data: Value to write
> @@ -118,7 +118,7 @@ int tc3589x_block_write(struct tc3589x *tc3589x, u8 reg, u8 length,
> * @tc3589x: Device to write to
> * @reg: Register to write
> * @mask: Mask of bits to set
> - * @values: Value to set
> + * @val: Value to set
> */
> int tc3589x_set_bits(struct tc3589x *tc3589x, u8 reg, u8 mask, u8 val)
> {
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog