Re: [Intel-wired-lan] [net-next PATCH 27/27] igb: Revert "igb: Revert support for build_skb in igb"

From: Jeff Kirsher
Date: Wed Oct 26 2016 - 13:22:51 EST


On Tue, 2016-10-25 at 11:39 -0400, Alexander Duyck wrote:
> This reverts commit f9d40f6a9921 ("igb: Revert support for build_skb in
> igb") and adds a few changes to update it to work with the latest version
> of igb. We are now able to revert the removal of this due to the fact
> that with the recent changes to the page count and the use of
> DMA_ATTR_SKIP_CPU_SYNC we can make the pages writable so we should not be
> invalidating the additional data added when we call build_skb.
>
> The biggest risk with this change is that we are now not able to support
> full jumbo frames when using build_skb. Instead we can only support up
> to
> 2K minus the skb overhead and padding offset.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part