Re: [PATCH] advansys: fix build warning for PCI=n

[Martin K. Petersen]

>>>>> "Arnd" == Arnd Bergmann <arnd@xxxxxxxx> writes:

Arnd> The advansys probe function tries to handle both ISA and PCI
Arnd> cases, each hidden in an #ifdef when unused. This leads to a
Arnd> warning indicating that when PCI is disabled we could be using
Arnd> uninitialized data:

Arnd> drivers/scsi/advansys.c: In function âadvansys_board_foundâ:
Arnd> drivers/scsi/advansys.c:11036:5: error: âretâ may be used
Arnd> uninitialized in this function [-Werror=maybe-uninitialized]
Arnd> drivers/scsi/advansys.c:10928:28: note: âretâ was declared here
Arnd> drivers/scsi/advansys.c:11309:8: error: âshare_irqâ may be used
Arnd> uninitialized in this function [-Werror=maybe-uninitialized]
Arnd> drivers/scsi/advansys.c:10928:6: note: âshare_irqâ was declared
Arnd> here

Arnd> This cannot happen in practice because the hardware in question
Arnd> only exists for PCI, but changing the code to just error out here
Arnd> is better for consistency and avoids the warning.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering