Re: [PATCH] x86: quirks: hide maybe-uninitialized warning

From: Ingo Molnar
Date: Thu Oct 27 2016 - 02:23:49 EST



* Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:

> On Mon, Oct 24, 2016 at 05:33:18PM +0200, Arnd Bergmann wrote:
> > gcc -Wmaybe-uninitialized detects that quirk_intel_brickland_xeon_ras_cap
> > uses uninitialized data when CONFIG_PCI is not set:
> >
> > arch/x86/kernel/quirks.c: In function âquirk_intel_brickland_xeon_ras_capâ:
> > arch/x86/kernel/quirks.c:641:13: error: âcapid0â is used uninitialized in this function [-Werror=uninitialized]
> >
> > However, the function is also not called in this configuration, so we
> > can avoid the warning by moving the existing #ifdef to cover it as well.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> This fixes 3637efb00864 ("x86/mce: Add PCI quirks to identify Xeons with
> machine check recovery"), which appeared in v4.9-rc1. I assume it will be
> merged for v4.9 via the x86 tree, as 3637efb00864 was.
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Yeah, that's the plan - thanks!

Ingo