Re: [PATCH v12 0/5] Goodix touchscreen enhancements

From: Bastien Nocera
Date: Thu Oct 27 2016 - 10:07:08 EST


On Sat, 2016-09-10 at 20:57 +0300, Irina Tirdea wrote:
> This is an update for a previous set of patches [1] with enhancements
> for the Goodix touchscreens. The first 3 patches are leftovers from
> the previous patchset (with minor changes due to rebase), while the
> last 2 patches are new.
>
> Thanks,
> Irina
>
> [1] https://lkml.org/lkml/2015/11/19/241
>
> Changes in v12:
> Â- add documentation for configuration firmware update
> Â- minor changes due to rebase
> Â- add 2 new patches to fix reset sequence and add support for gt9157
>
> Previous changes:
> Â https://lkml.org/lkml/2015/11/19/241
>
> Irina Tirdea (5):
> Â Input: goodix - add sysfs interface to dump config
> Â Input: goodix - add support for ESD
> Â Input: goodix - add runtime power management support

I tested those 3 patches in their v11, but my test tablet's software is
currently broken. Until I find the time to regenerate install images,
I'll just do code reviews.

I assume the first 3 patches don't break anything on the device I
tested this on, but I'd like to make sure it was at least tested on
ACPI-based systems.

Can you mention somewhere on which devices those patches were tested?

Cheers

> Â Input: goodix - fix reset sequence
> Â Input: goodix - add support for gt9157
>
> Â.../bindings/input/touchscreen/goodix.txtÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ5 +
> ÂDocumentation/input/goodix.txtÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ84 +++++
> Âdrivers/input/touchscreen/goodix.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 346
> +++++++++++++++++++--
> Â3 files changed, 415 insertions(+), 20 deletions(-)
> Âcreate mode 100644 Documentation/input/goodix.txt
>