Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

From: Heikki Krogerus
Date: Fri Oct 28 2016 - 04:22:00 EST


Hi Andy,

On Thu, Oct 27, 2016 at 07:56:10PM +0300, Andy Shevchenko wrote:
> On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote:
> > Add a set_ldisc function to enable/disable IrDA SIR mode according to
> > the new line discipline.
>
> Thanks for the patch.
>
> Consider that not all implementations based on 8250_dw support IRDA
> feature. I suppose you need to read capability register bits 6 and 7,
> set flag and then based on the value accept or reject IRDA mode.
>
> P.S. Use -n when prepare patches to link them if you consider them
> dependent.

These are numbered? Or do you mean that please prefer sending
series of patches as threads?

% git send-email --thread...

Or something like that? I guess coverletter would be nice too.


Thanks,

--
heikki