Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

From: RafaÅ MiÅecki
Date: Tue Nov 01 2016 - 03:33:40 EST


On 1 November 2016 at 08:24, John Heenan <john@xxxxxxxx> wrote:
> @@ -5779,6 +5779,12 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw)
>
> ret = 0;
>
> + if(priv->fops == &rtl8723bu_fops) {

OK, let me be the first. Documentation/CodingStyle also says to use
space between "if" and "(" ;)


> @@ -6080,9 +6086,11 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
> goto exit;
> }
>
> - ret = rtl8xxxu_init_device(hw);
> - if (ret)
> - goto exit;
> + if(priv->fops != &rtl8723bu_fops) {

Same here.

I reviewed style only.

--
RafaÅ