Re: [PATCH] xattr: Fix setting security xattrs on sockfs

From: Andreas Gruenbacher
Date: Thu Nov 03 2016 - 12:01:09 EST


On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote:
> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote:
>> Casey, the first patch broke filesystems that support setxattr for some xattrs
>> but not security xattrs. Here's an updated patch; could you please test?
>
> This patch does not fix the problem. I am back to EOPTNOTSUP.

Ah, I forgot to register the new sockfs xattr handler. Does this help?

Thanks,
Andreas

---
net/socket.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/socket.c b/net/socket.c
index 816392a..9820725 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = {

static const struct xattr_handler *sockfs_xattr_handlers[] = {
&sockfs_xattr_handler,
+ &sockfs_security_xattr_handler,
NULL
};

--
2.7.4