Re: [PATCH] staging: st-cec: add parentheses around complex macros

[Benjamin Gaignard]

Thanks,

Acked-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>

2016-11-04 8:58 GMT+01:00 Maninder Singh <maninder.s2@xxxxxxxxxxx>:
> This patch fixes the following checkpatch.pl error:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Maninder Singh <maninder.s2@xxxxxxxxxxx>
> ---
>  drivers/staging/media/st-cec/stih-cec.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 2143448..b22394a 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -108,11 +108,11 @@
>
>  /* Constants for CEC_BIT_TOUT_THRESH register */
>  #define CEC_SBIT_TOUT_47MS BIT(1)
> -#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1)
> +#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1))
>  #define CEC_SBIT_TOUT_50MS BIT(2)
>  #define CEC_DBIT_TOUT_27MS BIT(0)
>  #define CEC_DBIT_TOUT_28MS BIT(1)
> -#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1)
> +#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1))
>
>  /* Constants for CEC_BIT_PULSE_THRESH register */
>  #define CEC_BIT_LPULSE_03MS BIT(1)
> --
> 1.7.9.5
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog