Re: [PATCH 3/8] writeback: mark background writeback as such

From: Jan Kara
Date: Sat Nov 05 2016 - 18:26:50 EST


On Tue 01-11-16 15:08:46, Jens Axboe wrote:
> If we're doing background type writes, then use the appropriate
> background write flags for that.
>
> Signed-off-by: Jens Axboe <axboe@xxxxxx>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> include/linux/writeback.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 50c96ee8108f..c78f9f0920b5 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -107,6 +107,8 @@ static inline int wbc_to_write_flags(struct writeback_control *wbc)
> {
> if (wbc->sync_mode == WB_SYNC_ALL)
> return REQ_SYNC;
> + else if (wbc->for_kupdate || wbc->for_background)
> + return REQ_BACKGROUND;
>
> return 0;
> }
> --
> 2.7.4
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR