Re: [PATCH v4] poly1305: generic C can be faster on chips with slow unaligned access

From: Martin Willi
Date: Tue Nov 08 2016 - 03:01:48 EST



> By using the unaligned access helpers, we drastically improve
> performance on small MIPS routers that have to go through the
> exception fix-up handler for these unaligned accesses.

I couldn't measure any slowdown here, so:

Acked-by: Martin Willi <martin@xxxxxxxxxxxxxx>

> -ÂÂÂÂÂÂÂdctx->s[0] = le32_to_cpuvp(key +ÂÂ0);
> +ÂÂÂÂÂÂÂdctx->s[0] = get_unaligned_le32(key +ÂÂ0);

Not sure what the exact alignment rules for key/iv are, but maybe we
want to replace the same function in chacha20_generic.c as well?

Martin