Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

From: Arnd Bergmann
Date: Tue Nov 08 2016 - 10:11:28 EST


On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote:
>
> Hi Arnd,
>
> Thanks for the reference.
>
> I think the i2c interface doesn't fully satisfy our requirements as we
> need more than just a slave bus address when accessing the slave device
> (which I think is what i2c uses). We also need to pass "offset" and
> "mod_mask" arguments to the djtag adapter to access specific registers
> in the slave device.

Ok. Are those values constant per device, or maybe a range? We may want to
include those in the reg property as well then.

Arnd