Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP

From: Thomas Gleixner
Date: Tue Nov 08 2016 - 15:41:50 EST


On Tue, 8 Nov 2016, Borislav Petkov wrote:
>
> Also, this fixes another bug where machine_check_poll() would clear
> mce.tsc unconditionally even if we requested precise MCP_TIMESTAMP
> logging.

> @@ -713,7 +713,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
> m.misc = 0;
> m.addr = 0;
> m.bank = i;
> - m.tsc = 0;

That does not make any sense. Where is m.tsc initialized? I couldn't find
any place which does, except this and the conditional clear farther down in
that function.

Thanks,

tglx