Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings

From: David Miller
Date: Wed Nov 09 2016 - 13:26:07 EST


From: Philippe Reynes <tremyfr@xxxxxxxxx>
Date: Sun, 6 Nov 2016 15:02:32 +0100

> When moving from typhoon_get_settings to typhoon_getlink_ksettings
> in the commit f7a5537cd2a5 ("net: 3com: typhoon: use new api
> ethtool_{get|set}_link_ksettings"), we use a local variable supported
> but we forgot to update the struct ethtool_link_ksettings with
> this value.
>
> We also initialize advertising to zero, because otherwise it may
> be uninitialized if no case of the switch (tp->xcvr_select) is used.
>
> Signed-off-by: Philippe Reynes <tremyfr@xxxxxxxxx>
> ---
> Changelog:
> v2:
> - remove a duplicate "commit" in the commit log

Applied.