Re: [PATCH v10 2/6] mfd: lpc_ich: Rename lpc-ich driver

From: Andy Shevchenko
Date: Thu Nov 10 2016 - 11:02:46 EST


On Thu, 2016-11-10 at 17:00 +0800, Tan Jui Nee wrote:
> This patch follows the example of mfd/wm831x to rename the driver
> from "lpc_ich" to "lpc_ich_core".
>
> Signed-off-by: Tan Jui Nee <jui.nee.tan@xxxxxxxxx>
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> Changes in V10:
> - No change
>
> Changes in V9:
> - Remove the filename from the header of lpc_ich_core.c
> (suggested by Lee).
>
> Changes in V8:
> - Update new file name with lpc_ich_core.c at description of
> source file.
> - Rework Makefile with new source file name lpc_ich_apl.c.
>
> Changes in V7:
> - No change
>
> Changes in V6:
> - none, just a subject line and commit message change.
>
> Âdrivers/mfd/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 1 +
> Âdrivers/mfd/{lpc_ich.c => lpc_ich_core.c} | 2 --
> Â2 files changed, 1 insertion(+), 2 deletions(-)
> Ârename drivers/mfd/{lpc_ich.c => lpc_ich_core.c} (99%)
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 9834e66..06a91ea 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -159,6 +159,7 @@ obj-$(CONFIG_PMIC_ADP5520) += adp5520.o
> Âobj-$(CONFIG_MFD_KEMPLD) += kempld-core.o
> Âobj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO) +=
> intel_quark_i2c_gpio.o
> Âobj-$(CONFIG_LPC_SCH) += lpc_sch.o

> +lpc_ich-objs := lpc_ich_core.o

Put this line after...

> Âobj-$(CONFIG_LPC_ICH) += lpc_ich.o

...this one. And you will easily see the issue in next patch.

> Âobj-$(CONFIG_MFD_RDC321X) += rdc321x-southbridge.o
> Âobj-$(CONFIG_MFD_JANZ_CMODIO) += janz-cmodio.o

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy