Re: [patch v5] i2c: mux: mellanox: add driver

From: Peter Rosin
Date: Fri Nov 11 2016 - 02:36:15 EST


On 2016-11-10 13:56, Vadim Pasternak wrote:
>
>
>> -----Original Message-----
>> From: Peter Rosin [mailto:peda@xxxxxxxxxx]
>> Sent: Thursday, November 10, 2016 1:13 PM
>> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; wsa@xxxxxxxxxxxxx
>> Cc: linux-i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx;
>> Michael Shych <michaelsh@xxxxxxxxxxxx>
>> Subject: Re: [patch v5] i2c: mux: mellanox: add driver
>>
>> [resend to all, got the wrong button, sorry]
>>
>> On 2016-11-10 11:42, Peter Rosin wrote:
>>> On 2016-11-03 06:20, Vadim Pasternak wrote:
>>>> Hi,
>>>>
>>>> I see that this patch has not been picked-up yet for i2c-next.
>>>> Is it possible it was missed from some reason?
>>>
>>> Yes, apparently, really sorry about that!
>>>
>>> I'll put it in a branch and make a pull request for Wolfram (but that
>>> is a bit new for me, we'll see how it goes).
>>
>> But now that I looked again, I noticed that the source is dual licensed and yet
>> your MODULE_LICENSE tag says only "GPL v2". I.e. the same issue your i2c
>> master driver had that Vladimir Zapolskiy noticed.
>>
>> Please fix this, and it might be a good idea to take a look in your other drivers as
>> well in case you have further problems in this department...
>
> Hi Peter,
>
> Thank you for reply.
> I'll re-submit it from the current i2c next branch.
> Since I'll fix the license, I guess I should issue it as "patch v6". Right?

Sounds right, yes.

Cheers,
Peter