Re: [PATCH] Security: selinux - Improvement in code readability when

From: Paul Moore
Date: Fri Nov 11 2016 - 21:29:35 EST


On Fri, Nov 11, 2016 at 3:48 AM, Shailendra Verma
<shailendra.v@xxxxxxxxxxx> wrote:
> From: "Shailendra Verma" <shailendra.v@xxxxxxxxxxx>
>
> There is no need to call kfree() if memdup_user() fails, as no memory
> was allocated and the error in the error-valued pointer should be returned.
>
> Signed-off-by: Shailendra Verma <shailendra.v@xxxxxxxxxxx>
> ---
> security/selinux/selinuxfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Hello Shailendra,

Thank you for your patch, but I prefer the readability of the code as
it currently stands.

--
paul moore
www.paul-moore.com