Re: [PATCH] Input: psmouse - disable automatic probing of BYD touchpads

From: Pali RohÃr
Date: Sat Nov 12 2016 - 14:40:37 EST


On Saturday 12 November 2016 20:15:45 Dmitry Torokhov wrote:
> BYD automatic protocol detection is extremely unreliable and is often
> triggers false positives on regular mice, Sentelic touchpads, and
> other devices. BYD has several documents that have recommended
> detection sequence, but they conflict with each other and, as far as
> I can see, still would not produce unique enough output to reliably
> differentiate BYD from other PS/2 devices.
>
> OEMs sourcing BYD devices also do not do us any favors by not
> supplying any reasonable DMI data and instead leaving turds like "To
> Be Filled By O.E.M." in place of vendor data, or "System Serial
> Number" as serial number.
...
> echo -n "byd" > /sys/bus/serio/devices/serio1/drvctl

I agree, if we cannot detect BYD devices correctly without breaking
other non-BYD devices then detection must be done by user...

So you can add my Reviewed-by: Pali RohÃr to this patch.

Anyway, BYD show Linux as supported OS for their devices. It is really
rude from BYD that they show Linux as supported OS, but Linux driver is
reverse-engineered by community and they do not want to cooperate and at
least provide some useful documentation for detection...

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.