RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

[ASIX_Allan [Home]]

Hi Jon,

It seems the AX88772x dongle had been unexpectedly removed while running the
ax88772_suspend() routine. If yes, you might see these error messages
because the hardware had been absent.    

---
Best regards,
Allan Chou


-----Original Message-----
From: Jon Hunter [mailto:jonathanh@xxxxxxxxxx] 
Sent: Thursday, November 10, 2016 8:01 PM
To: robert.foss@xxxxxxxxxxxxx; freddy@xxxxxxxxxxx; Dean_Jenkins@xxxxxxxxxx;
Mark_Craske@xxxxxxxxxx; davem@xxxxxxxxxxxxx; ivecera@xxxxxxxxxx;
john.stultz@xxxxxxxxxx; vpalatin@xxxxxxxxxxxx; stephen@xxxxxxxxxxxxxxxxxx;
grundler@xxxxxxxxxxxx; changchias@xxxxxxxxx; allan@xxxxxxxxxxx;
andrew@xxxxxxx; tremyfr@xxxxxxxxx; colin.king@xxxxxxxxxxxxx;
linux-usb@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; vpalatin@xxxxxxxxxx
Subject: Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Robert,

On 29/08/16 14:32, robert.foss@xxxxxxxxxxxxx wrote:
> From: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> 
> From: Allan Chou <allan@xxxxxxxxxxx>
> 
> The change fixes AX88772x resume failure by
> - Restore incorrect AX88772A PHY registers when resetting
> - Need to stop MAC operation when suspending
> - Need to restart MII when restoring PHY
> 
> Signed-off-by: Allan Chou <allan@xxxxxxxxxxx>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> Tested-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>

After this commit, I have started seeing the following messages during
system suspend on various tegra boards using asix ethernet dongles ...

[  288.667010] PM: Syncing filesystems ... done.
[  288.672223] Freezing user space processes ... (elapsed 0.001 seconds)
done.
[  288.680505] Double checking all user space processes after OOM killer
disable... (elapsed 0.000 seconds) [  288.690193] Freezing remaining
freezable tasks ... (elapsed 0.001 seconds) done.
[  288.698987] Suspending console(s) (use no_console_suspend to debug) [
288.706605] asix 1-1:1.0 eth0: Failed to read reg index 0x0000: -19 [
288.706613] asix 1-1:1.0 eth0: Error reading Medium Status register:
ffffffed [  288.706621] asix 1-1:1.0 eth0: Failed to write reg index 0x0000:
-19 [  288.706629] asix 1-1:1.0 eth0: Failed to write Medium Mode mode to
0xfeed: ffffffed [  288.759167] PM: suspend of devices complete after 52.772
msecs

Interestingly, it only seems to happen if the ethernet is in a disconnected
state when entering suspend. I have not had chance to look at this any
further, but wanted to see if you had any thoughts.

Cheers
Jon

--
nvpublic