Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

From: Hans Verkuil
Date: Mon Nov 14 2016 - 10:00:10 EST


On 11/14/2016 03:59 PM, Stanimir Varbanov wrote:
> Hi,
>
> On 11/11/2016 02:11 PM, Javier Martinez Canillas wrote:
>> Hello Hans,
>>
>> On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>>> Hi Stanimir,
>>>
>>> Overall it looks good. As you saw, I do have some comments but nothing major.
>>>
>>> One question: you use qcom as the directory name. How about using qualcomm?
>>>
>>> It's really not that much longer and a bit more obvious.
>>>
>>> Up to you, though.
>>>
>>
>> It seems qcom is more consistent to the name used in most subsystems
>> for Qualcomm:
>>
>> $ find -name *qcom
>> ./arch/arm/mach-qcom
>> ./arch/arm64/boot/dts/qcom
>> ./Documentation/devicetree/bindings/soc/qcom
>> ./sound/soc/qcom
>> ./drivers/pinctrl/qcom
>> ./drivers/soc/qcom
>> ./drivers/clk/qcom
>>
>> $ find -name *qualcomm
>> ./drivers/net/ethernet/qualcomm
>
> Also qcom is the vendor prefix used in [1]
>
> [1] Documentation/devicetree/bindings/vendor-prefixes.txt
>

qcom it is, then :-)

Hans