Re: [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper

From: Srinivas Pandruvada
Date: Mon Nov 14 2016 - 12:14:31 EST


On Mon, 2016-11-14 at 17:41 +0100, Arnd Bergmann wrote:
> The newly added function uses two different prototypes depending
> on configuration, and one of them does not match the caller:
>
> drivers/cpufreq/intel_pstate.c: In function âcopy_cpu_funcsâ:
> drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to
> function âintel_pstate_use_acpi_profileâ
>
> This changes it to look like the other one.
Sorry about that.

>
> Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based
> algorithm for mobile class devices")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>

> ---
> Âdrivers/cpufreq/intel_pstate.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 65832f8eacdc..7153cf2d8e11 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1779,7 +1779,7 @@ static void intel_pstate_use_acpi_profile(void)
> Â get_target_pstate_use_cpu_load;
> Â}
> Â#else
> -static inline void intel_pstate_use_acpi_profile(struct pstate_funcs
> *funcs)
> +static inline void intel_pstate_use_acpi_profile(void)
> Â{
> Â}
> Â#endif